| Classes in this File | Line Coverage | Branch Coverage | Complexity | ||||
| AvoidInlineConditionalsCheck |
|
| 1.0;1 |
| 1 | //////////////////////////////////////////////////////////////////////////////// | |
| 2 | // checkstyle: Checks Java source code for adherence to a set of rules. | |
| 3 | // Copyright (C) 2001-2014 Oliver Burn | |
| 4 | // | |
| 5 | // This library is free software; you can redistribute it and/or | |
| 6 | // modify it under the terms of the GNU Lesser General Public | |
| 7 | // License as published by the Free Software Foundation; either | |
| 8 | // version 2.1 of the License, or (at your option) any later version. | |
| 9 | // | |
| 10 | // This library is distributed in the hope that it will be useful, | |
| 11 | // but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 | // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 | // Lesser General Public License for more details. | |
| 14 | // | |
| 15 | // You should have received a copy of the GNU Lesser General Public | |
| 16 | // License along with this library; if not, write to the Free Software | |
| 17 | // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | //////////////////////////////////////////////////////////////////////////////// | |
| 19 | package com.puppycrawl.tools.checkstyle.checks.coding; | |
| 20 | ||
| 21 | import com.puppycrawl.tools.checkstyle.api.Check; | |
| 22 | import com.puppycrawl.tools.checkstyle.api.TokenTypes; | |
| 23 | import com.puppycrawl.tools.checkstyle.api.DetailAST; | |
| 24 | ||
| 25 | /** | |
| 26 | * Detects inline conditionals. | |
| 27 | * | |
| 28 | * An example inline conditional is this: | |
| 29 | * <pre> | |
| 30 | * String a = getParameter("a"); | |
| 31 | * String b = (a==null || a.length<1) ? null : a.substring(1); | |
| 32 | * </pre> | |
| 33 | * | |
| 34 | * Rationale: Some developers find inline conditionals hard to read, | |
| 35 | * so their company's coding standards forbids them. | |
| 36 | * | |
| 37 | * @author lkuehne | |
| 38 | */ | |
| 39 | 1 | public class AvoidInlineConditionalsCheck extends Check |
| 40 | { | |
| 41 | @Override | |
| 42 | public int[] getDefaultTokens() | |
| 43 | { | |
| 44 | 1 | return new int[]{TokenTypes.QUESTION}; |
| 45 | } | |
| 46 | ||
| 47 | @Override | |
| 48 | public int[] getRequiredTokens() | |
| 49 | { | |
| 50 | 0 | return getDefaultTokens(); |
| 51 | } | |
| 52 | ||
| 53 | @Override | |
| 54 | public void visitToken(DetailAST aAST) | |
| 55 | { | |
| 56 | // the only place a QUESTION token can occur is in inline conditionals | |
| 57 | // so no need to do any further tricks here - pretty trivial Check! | |
| 58 | ||
| 59 | 3 | log(aAST.getLineNo(), aAST.getColumnNo(), "inline.conditional.avoid"); |
| 60 | 3 | } |
| 61 | } |