| 1 | |
|
| 2 | |
|
| 3 | |
|
| 4 | |
|
| 5 | |
|
| 6 | |
|
| 7 | |
|
| 8 | |
|
| 9 | |
|
| 10 | |
|
| 11 | |
|
| 12 | |
|
| 13 | |
|
| 14 | |
|
| 15 | |
|
| 16 | |
|
| 17 | |
|
| 18 | |
|
| 19 | |
package com.puppycrawl.tools.checkstyle.checks.coding; |
| 20 | |
|
| 21 | |
import com.google.common.collect.Sets; |
| 22 | |
import com.puppycrawl.tools.checkstyle.api.Check; |
| 23 | |
import com.puppycrawl.tools.checkstyle.api.DetailAST; |
| 24 | |
import com.puppycrawl.tools.checkstyle.api.FullIdent; |
| 25 | |
import com.puppycrawl.tools.checkstyle.api.TokenTypes; |
| 26 | |
import com.puppycrawl.tools.checkstyle.checks.CheckUtils; |
| 27 | |
import java.util.Set; |
| 28 | |
|
| 29 | |
|
| 30 | |
|
| 31 | |
|
| 32 | |
|
| 33 | |
|
| 34 | |
|
| 35 | |
|
| 36 | |
|
| 37 | |
|
| 38 | |
|
| 39 | |
|
| 40 | |
|
| 41 | |
|
| 42 | |
|
| 43 | |
|
| 44 | 1 | public class CovariantEqualsCheck extends Check |
| 45 | |
{ |
| 46 | |
|
| 47 | 1 | private final Set<DetailAST> mEqualsMethods = Sets.newHashSet(); |
| 48 | |
|
| 49 | |
@Override |
| 50 | |
public int[] getDefaultTokens() |
| 51 | |
{ |
| 52 | 1 | return new int[] {TokenTypes.CLASS_DEF, TokenTypes.LITERAL_NEW, }; |
| 53 | |
} |
| 54 | |
|
| 55 | |
@Override |
| 56 | |
public int[] getRequiredTokens() |
| 57 | |
{ |
| 58 | 0 | return getDefaultTokens(); |
| 59 | |
} |
| 60 | |
|
| 61 | |
@Override |
| 62 | |
public void visitToken(DetailAST aAST) |
| 63 | |
{ |
| 64 | 12 | mEqualsMethods.clear(); |
| 65 | 12 | boolean hasEqualsObject = false; |
| 66 | |
|
| 67 | |
|
| 68 | 12 | final DetailAST objBlock = aAST.findFirstToken(TokenTypes.OBJBLOCK); |
| 69 | 12 | if (objBlock != null) { |
| 70 | 11 | DetailAST child = objBlock.getFirstChild(); |
| 71 | 54 | while (child != null) { |
| 72 | 43 | if (child.getType() == TokenTypes.METHOD_DEF |
| 73 | |
&& CheckUtils.isEqualsMethod(child)) |
| 74 | |
{ |
| 75 | 15 | if (hasObjectParameter(child)) { |
| 76 | 6 | hasEqualsObject = true; |
| 77 | |
} |
| 78 | |
else { |
| 79 | 9 | mEqualsMethods.add(child); |
| 80 | |
} |
| 81 | |
} |
| 82 | 43 | child = child.getNextSibling(); |
| 83 | |
} |
| 84 | |
|
| 85 | |
|
| 86 | 11 | if (!hasEqualsObject) { |
| 87 | 5 | for (DetailAST equalsAST : mEqualsMethods) { |
| 88 | 4 | final DetailAST nameNode = equalsAST |
| 89 | |
.findFirstToken(TokenTypes.IDENT); |
| 90 | 4 | log(nameNode.getLineNo(), nameNode.getColumnNo(), |
| 91 | |
"covariant.equals"); |
| 92 | 4 | } |
| 93 | |
} |
| 94 | |
} |
| 95 | 12 | } |
| 96 | |
|
| 97 | |
|
| 98 | |
|
| 99 | |
|
| 100 | |
|
| 101 | |
|
| 102 | |
|
| 103 | |
|
| 104 | |
private boolean hasObjectParameter(DetailAST aAST) |
| 105 | |
{ |
| 106 | |
|
| 107 | 15 | final DetailAST paramsNode = aAST.findFirstToken(TokenTypes.PARAMETERS); |
| 108 | 15 | if (paramsNode.getChildCount() != 1) { |
| 109 | 0 | return false; |
| 110 | |
} |
| 111 | |
|
| 112 | |
|
| 113 | 15 | final DetailAST paramNode = |
| 114 | |
paramsNode.findFirstToken(TokenTypes.PARAMETER_DEF); |
| 115 | 15 | final DetailAST typeNode = paramNode.findFirstToken(TokenTypes.TYPE); |
| 116 | 15 | final FullIdent fullIdent = FullIdent.createFullIdentBelow(typeNode); |
| 117 | 15 | final String name = fullIdent.getText(); |
| 118 | 15 | return ("Object".equals(name) || "java.lang.Object".equals(name)); |
| 119 | |
} |
| 120 | |
} |